Feature: add deleted groups #36
Conversation
|
Hi @EstelleBarnoud thanks so much for opening this feature request and providing the context as to why you would like to include the deleted records for historical modeling. My main concern is if these deleted records could possibly have the same group_id as an existing group. I want to confirm that the downstream joins in the dbt_zendesk package would not result in duplicates if we remove the filter that currently exists in the staging model. If not, then I think it would be relevant to include these deleted records in the downstream joins as it would help paint a proper historical picture. Would you be able to confirm that you do not see duplicate ids in your data? In the meantime I will confirm this with our product team to get further confidence. |
Are you a current Fivetran customer?
Yes, part of dbt Labs internal analytics team!
What change(s) does this PR introduce?
Enable historical modeling: updated the
stg_zendesk__groupmodel to keep deleted groups. Addedis_deletedtag to enable filtering in downstream models.Use case: building a historical model of each ticket states at each field update. Would need to override the package model to get group name for historical tickets with deleted groups:
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
The
stg_zendesk__groupis a usually small table and is only ever used to join in group names to other downstream models in thefivetran/zendeskpackage. This means models will only be enriched better downstream for historical tickets.Note: the
is_deletedtag can be used by teams to filter out outdated records in models outside of these packages, but leaving as is is non breaking.Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Installed
fivetran/zendeskpackage (team is only usingfivetran/zendesk_source) & build all package models:Results:
Validation on project: test is now passing
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
☀️
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.